Remove json serialization for notify validation #14847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
For the webhook notification, the start body only accepts variables whom transpose to json dict.
E.g : {{job_metadata}} =
All other variables such as {{job.id}} which are primitives (int, str, float, etc) do not pass the validation.
They are not dict type and the below check does not allow {{job.scm_reivsion}} etc as requested by #14410
This patch loosens up this validation to just check for jinja template exception.
related: #14410
ISSUE TYPE
COMPONENT NAME