Bump axios UI dep to 1.6.z #14954
Merged
Bump axios UI dep to 1.6.z #14954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:ui
dependencies
marshmalien
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Reviewed the crowd-sourced migration guide issues and didn't find instances where we used functions involved in a breaking change. Pulled down and with a fresh build I manually tested form submission, login/logout, job runs, syncs, advanced search, and all requests worked as expected.
mabashian
force-pushed
the
bump-axios-1.6
branch
from
d2749f1
to
312f7dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I don't anticipate any breaking changes here based on this crowd-sourced migration guide (no official guide was provided afaik). Our use of axios is isolated to just this bit of code: https://github.com/ansible/awx/blob/devel/awx/ui/src/api/Base.js#L12-L18. All of our API requests inherit from this base class so if something did break it'd be pretty apparent as data would stop flowing to the UI. I did some manual verification that data was loading on pages correctly as well as websocket messages were still being received as expected.
ISSUE TYPE
COMPONENT NAME