Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prune dangle image periodically #14957

Merged

Conversation

TheRealHaoLiu
Copy link
Member

@TheRealHaoLiu TheRealHaoLiu commented Mar 6, 2024

DO NOT MERGE TILL ANSIBLE RUNNER PR MERGED Merged

SUMMARY

pairs with ansible/ansible-runner#1342

this fix the problem of us forcefully remove images when setting changing ee image that's being used in a job causing the job to fail

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API
AWX VERSION
awx: 23.9.1.dev10+g8cfd4b3d49.d20240306
ADDITIONAL INFORMATION

pairs with ansible/ansible-runner#1342

this fix the problem of us forcefully remove images when setting changing ee image that's being used in a job causing the job to fail
@TheRealHaoLiu
Copy link
Member Author

branch with modified requirements for testing https://github.com/TheRealHaoLiu/awx/tree/prune-dangle-container-images-qe

Copy link
Contributor

@jbradberry jbradberry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

@TheRealHaoLiu TheRealHaoLiu requested a review from CFSNM March 6, 2024 18:48
@TheRealHaoLiu TheRealHaoLiu removed the request for review from shanemcd March 7, 2024 21:20
@gundalow gundalow changed the title Prune dangle image periodically [ON HOLD-dependency needs merging first] Prune dangle image periodically Mar 8, 2024
@TheRealHaoLiu TheRealHaoLiu merged commit dd91601 into ansible:devel Mar 12, 2024
25 checks passed
@TheRealHaoLiu TheRealHaoLiu deleted the prune-dangle-container-images branch March 12, 2024 14:58
@gundalow gundalow changed the title [ON HOLD-dependency needs merging first] Prune dangle image periodically Prune dangle image periodically Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants