Setting modification to address requests from UI_NEXT devs #14996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheRealHaoLiu
changed the title
TheRealHaoLiu
requested review from
fosterseth,
jbradberry,
chrismeyersfsu and
AlanCoding
AlanCoding
reviewed
Mar 15, 2024
| @@ -845,6 +850,7 @@ | |||
| help_text=_('Enable preview of new user interface.'), | |||
| category=_('System'), | |||
| category_slug='system', | |||
| hidden=True, | |||
There was a problem hiding this comment.
The one thing I'm not getting from this is how this list of settings to hide came about. Will this just lead to complaints that we hid these?
There was a problem hiding this comment.
this field only gets read by UI_NEXT
on UI_NEXT itself we don't need to show enabling UI_NEXT
- Add hidden to indicate to UI_NEXT to hide the field - Add warning_text to indicate to UI_NEXT to display the warning when specific setting is modified - Address some non required field being marked as required
TheRealHaoLiu
force-pushed
the
james-wishlist
branch
from
e3917ea
to
35de4ba
Compare
fosterseth
reviewed
Mar 18, 2024
| @@ -825,6 +828,7 @@ | |||
| help_text=_('Max number of hosts to allow to be created in a single bulk action'), | |||
| category=_('Bulk Actions'), | |||
| category_slug='bulk', | |||
| hidden=True, | |||
There was a problem hiding this comment.
why are these other settings being hidden?
There was a problem hiding this comment.
they are not being shown on the UI anyway, and currently its hard coded for the UI to not show these settings
UI_NEXT want this to be dynamic and be determined by the API response
fosterseth
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION