Add OpenShift Virtualization Inventory source option #15047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:api
component:awx_collection
TheRealHaoLiu
changed the title
fosterseth
reviewed
Jun 13, 2024
fosterseth
reviewed
Jun 13, 2024
|
still need to find a ocp that's capable of hosting kubevirt VM to test this... can't afford that AWS Baremetal node, lol |
- generate migration for adding ovirt inventory source - fix python and UI linting issue - make the UI actually work
for credential of CLOUD_PROVIDER inventory source...
fix ``` tools_awx_1 | 2024-06-14 15:39:23,424 ERROR [63b8bfcc] awx.main.tasks.jobs inventory_update 8 (running) Post run hook errored. tools_awx_1 | Traceback (most recent call last): tools_awx_1 | File "/awx_devel/awx/main/tasks/jobs.py", line 637, in run tools_awx_1 | self.post_run_hook(self.instance, status) tools_awx_1 | File "/awx_devel/awx/main/tasks/jobs.py", line 1669, in post_run_hook tools_awx_1 | if getattr(settings, '%s_EXCLUDE_EMPTY_GROUPS' % src.upper()): tools_awx_1 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ tools_awx_1 | File "/awx_devel/awx/conf/settings.py", line 540, in __getattr_without_cache__ tools_awx_1 | return getattr(self._wrapped, name) tools_awx_1 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ tools_awx_1 | File "/awx_devel/awx/conf/settings.py", line 441, in __getattr__ tools_awx_1 | return self._get_default(name) tools_awx_1 | ^^^^^^^^^^^^^^^^^^^^^^^ tools_awx_1 | File "/awx_devel/awx/conf/settings.py", line 415, in _get_default tools_awx_1 | return getattr(self.default_settings, name) tools_awx_1 | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ tools_awx_1 | AttributeError: 'Settings' object has no attribute 'OPENSHIFT_VIRTUALIZATION_EXCLUDE_EMPTY_GROUPS' ```
|
ok tested against a cluster that actually have kubevirt machines |
fosterseth
reviewed
Jun 14, 2024
fosterseth
approved these changes
Jun 14, 2024
9 tasks
|
I'll add the docs for this! See #15274. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding OpenShift Virtualization inventory source
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION