Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RBAC] Rename managed role definitions, and move migration logic here #15087

Merged
merged 2 commits into from Apr 10, 2024

Conversation

AlanCoding
Copy link
Member

SUMMARY

This changes the names of the pre-created roles. Here I'll give a dump of what it produces:

In [4]: list(RoleDefinition.objects.values_list('name', flat=True))
Out[4]: 
['Project Admin',
 'Organization Project Admin',
 'Project Use',
 'WorkflowJobTemplate Admin',
 'Organization WorkflowJobTemplate Admin',
 'WorkflowJobTemplate Execute',
 'WorkflowJobTemplate Approve',
 'Inventory Admin',
 'Organization Inventory Admin',
 'Inventory Use',
 'Inventory Adhoc',
 'NotificationTemplate Admin',
 'Organization NotificationTemplate Admin',
 'JobTemplate Admin',
 'Organization JobTemplate Admin',
 'JobTemplate Execute',
 'Organization Member',
 'Organization Audit',
 'Credential Admin',
 'Organization Credential Admin',
 'Credential Use',
 'ExecutionEnvironment Admin',
 'Organization ExecutionEnvironment Admin',
 'InstanceGroup Admin',
 'Organization InstanceGroup Admin',
 'InstanceGroup Use',
 'Team Admin',
 'Organization Team Admin',
 'Team Member',
 'Organization Admin']

We would prefer not to change these later, so ideally this is final.

internal: AAP-22517

This also moves the managed role pre-create logic into here from DAB, which just seems more direct because this is the only thing that uses this.

ISSUE TYPE
  • New or Enhanced Feature
COMPONENT NAME
  • API

@AlanCoding
Copy link
Member Author

Tests all look good. I'm good to merge this to the feature branch.

@AlanCoding AlanCoding merged commit 7010c70 into ansible:feature_dab_rbac Apr 10, 2024
20 of 22 checks passed
AlanCoding added a commit that referenced this pull request Apr 10, 2024
…#15087)

* Rename managed role definitions, and move migration logic here

* Fix naming capitalization
AlanCoding added a commit that referenced this pull request Apr 10, 2024
…#15087)

* Rename managed role definitions, and move migration logic here

* Fix naming capitalization
AlanCoding added a commit that referenced this pull request Apr 11, 2024
…#15087)

* Rename managed role definitions, and move migration logic here

* Fix naming capitalization
AlanCoding added a commit that referenced this pull request Apr 11, 2024
…#15087)

* Rename managed role definitions, and move migration logic here

* Fix naming capitalization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant