Fix instance peering pagination #15108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fosterseth
force-pushed
the
fix_ui_peers_association
branch
2 times, most recently
from
aadba40
to
6de06e1
Compare
Currently the association box displays a list of available instances/addresses that can be peered to. The pagination issue arises as follows: - fetch 5 instances (based on page_size) - filter these instances down based on some criteria (like is_internal: false) - show results Filtering down the results inside of the fetch method results in pagnation errors (may return fewer than 5, for example) instead, do the filtering by API queries. That way the pagination count will be correct. Signed-off-by: Seth Foster <fosterbseth@gmail.com>
fosterseth
force-pushed
the
fix_ui_peers_association
branch
from
6de06e1
to
f9fac29
Compare
|
reminder: may need to backport update: don't need backport - receptor address only lives in devel at the time of merging this |
akus062381
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Currently the association box displays a list of available instances/addresses that can be peered to.
The pagination issue arises as follows:
Filtering down the results inside of the fetch method results in pagnation errors (may return fewer than 5, for example)
instead, do the filtering by API queries. That way the pagination count will be correct.
ISSUE TYPE
COMPONENT NAME
Video of bug
2024-04-12.12-54-28.mp4
Video of fix
2024-04-12.15-22-03.mp4