Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test isolation problem with settings assignment #15242

Closed
wants to merge 1 commit into from

Conversation

AlanCoding
Copy link
Member

SUMMARY

These tests introduced a flaky failure:

  File "/awx_devel/awx/main/tests/unit/test_settings.py", line 32, in test_default_settings
    assert default_val == snapshot_val, f'Setting for {k} does not match shapshot:\nsnapshot: {snapshot_val}\ndefault: {default_val}'
AssertionError: Setting for OPTIONAL_API_URLPATTERN_PREFIX does not match shapshot:
  snapshot: 
  default: foo
assert 'foo' == ''

AFAIK this was only observed in DAB with downstream testing, but I see no reason it wouldn't also occur in AWX since it's a very generic reason that it happens. The stale "foo" value is left around at the end of the test.

ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • API

@chrismeyersfsu
Copy link
Member

Hmm, thought I fixed this here #15237

@AlanCoding
Copy link
Member Author

Maybe so.

@AlanCoding AlanCoding closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants