Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Views breakout #2341

Merged
merged 3 commits into from
Oct 1, 2018
Merged

Views breakout #2341

merged 3 commits into from
Oct 1, 2018

Conversation

wwitzel3
Copy link
Contributor

SUMMARY

Start of the views breakout. Fix bug in mixin from previous merge.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • API

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

  • tox : FAILURE in 1m 56s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

  • tox : FAILURE in 1m 35s

@softwarefactory-project-zuul
Copy link
Contributor

Build failed.

  • tox : FAILURE in 1m 31s

@wwitzel3
Copy link
Contributor Author

These pass for me when running make test and I can't seem to figure out why they are failing here.

============ 2315 passed, 4 skipped, 15 warnings in 106.95 seconds =============

@wwitzel3
Copy link
Contributor Author

The point of this change is to get the directory structure in place so I can start peeling out views in to their own files. By doing this initial change first it prevents a merge conflict from happening every time we rip something out of views.py and lets is actually start to gain ground on taming this massive out of control file.

@wwitzel3 wwitzel3 mentioned this pull request Sep 28, 2018
Merged
@wwitzel3 wwitzel3 removed the request for review from chrismeyersfsu October 1, 2018 13:46
@rooftopcellist rooftopcellist self-requested a review October 1, 2018 14:10
@matburt matburt merged commit e6dbf71 into ansible:devel Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlanCoding AlanCoding AlanCoding approved these changes

@jakemcdermott jakemcdermott jakemcdermott approved these changes

@rooftopcellist rooftopcellist rooftopcellist approved these changes

Assignees
No one assigned
Labels
component:api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wwitzel3 @AlanCoding @jakemcdermott @rooftopcellist @matburt