Allow relaunching other user jobs with public vars #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
AlanCoding
force-pushed
the
passwords_and_relaunching
branch
from
8e826af
to
29c8d11
Compare
|
Build failed.
|
AlanCoding
force-pushed
the
passwords_and_relaunching
branch
from
29c8d11
to
5720601
Compare
|
Build succeeded.
|
|
Note that if we ever tackle #3476 , we'll need to rethink this. |
I think I'm okay with this. This method might not even need to change if we do that, because we're checking read access to the job already. |
|
Build succeeded (gate pipeline).
|
This was referenced Sep 5, 2021
This was referenced Oct 6, 2022
This was referenced Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The previous check here was too restrictive.
If you can read the job then you can see the variables that the other user provided, except for encrypted variables. Thus, there is no security difference between before vs. after this change.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION