Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade ptyprocess #3991

Merged

Conversation

shanemcd
Copy link
Member

@shanemcd shanemcd commented Jun 3, 2019

@shanemcd shanemcd requested a review from AlanCoding June 3, 2019 17:43
@shanemcd
Copy link
Member Author

shanemcd commented Jun 3, 2019

Also verified w/ OOB non-unit tests

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@AlanCoding
Copy link
Member

It would be good to add to the note that this is only necessary for python2 virtual environments. I tried to look into an alternative where we add an entry of ptyprocess==0.5.2; python_version < '3' to the requirements.in file. Doing that, I found this in the py2 vs py3 requirements:

87c91
< ptyprocess==0.6.0         # via pexpect
---
> ptyprocess==0.5.2 ; python_version < "3"

So it would be automatically added as a conditional requirement for the python2 reqs, but would be added as most recent to the python3 reqs. These need to be manually re-combined in the (still combined) Ansible venv requirements file. That would be possible, but doesn't follow the same pattern as our other manual steps.

Since an upstream fix may be coming sometime soon, I agree with avoiding that work for pinning it for both py2 and py3 until upstream fixes it.

@ryanpetrello
Copy link
Contributor

@shanemcd once this gets fixed upstream (sounds like it's happening soon), let's just remove this pin.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 1829017 into ansible:devel Jun 3, 2019
@shanemcd shanemcd deleted the downgrade-ptyprocess branch June 26, 2020 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants