Set reasonable default for MAX_FORKS #5674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanpetrello
approved these changes
Jan 15, 2020
awx/main/conf.py
Outdated
| register( | ||
| 'MAX_FORKS', | ||
| field_class=fields.IntegerField, | ||
| allow_null=False, | ||
| default=0, | ||
| default=100, |
There was a problem hiding this comment.
Maybe? Bumping it up to 200 sounds fine for those types of users - Though if we take 25 forks per 4GB as our baseline it'd be good to know if 200 would prevent a bad time for all the folks just running our recommended 4GB minimum.
Based on our earlier chat, 100 was on the upper side of reasonable for a lot of scenarios. However, since this meant to be more of a sanity check I see your point that nudging this closer to 200 is probably the way to go. Some users might be doing alright with > 100 and so the additional warnings on upgrade wouldn't be welcome.
|
Build failed.
|
jakemcdermott
force-pushed
the
fix-5142-2
branch
from
8613869
to
72f9609
Compare
jakemcdermott
force-pushed
the
fix-5142-2
branch
from
72f9609
to
a6f063b
Compare
jakemcdermott
changed the title
|
Build succeeded.
|
ryanpetrello
approved these changes
Jan 15, 2020
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Set a reasonably sane default for
MAX_FORKS.#5142