Fail early processing project factory

[AlanCoding]

SUMMARY

In data generators, don't let JT processing continue with failed projects

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

• API

AWX VERSION

9.2.0

ADDITIONAL INFORMATION

error before:

tests/api/test_alan.py::TestAlan::test_project FAILED                                                                                                                [100%]

================================================================================= FAILURES =================================================================================
__________________________________________________________________________ TestAlan.test_project ___________________________________________________________________________
Traceback (most recent call last):
  File "/Users/alancoding/Documents/repos/tower-qa/tests/api/test_alan.py", line 184, in test_project
    factories.job_template()
  File "/Users/alancoding/Documents/repos/tower-qa/tests/lib/fixtures/factory_fixtures.py", line 199, in __call__
    return self._has_create_factory(request=self.request, **kwargs)
  File "/Users/alancoding/Documents/repos/tower-qa/tests/lib/fixtures/factory_fixtures.py", line 59, in __call__
    has_create = cls.model(connection).create(**kwargs)
  File "/Users/alancoding/Documents/tower/awxkit/awxkit/api/pages/job_templates.py", line 179, in create
    self.connection).post(payload))
  File "/Users/alancoding/Documents/tower/awxkit/awxkit/api/pages/page.py", line 307, in post
    return self.page_identity(r, request_json=json)
  File "/Users/alancoding/Documents/tower/awxkit/awxkit/api/pages/page.py", line 260, in page_identity
    raise exc.BadRequest(exc_str, data)
awxkit.exceptions.BadRequest: {'playbook': ['Playbook not found for project.']}

error after:

tests/api/test_alan.py::TestAlan::test_project FAILED                                                                                                                [100%]

================================================================================= FAILURES =================================================================================
__________________________________________________________________________ TestAlan.test_project ___________________________________________________________________________
Traceback (most recent call last):
  File "/Users/alancoding/Documents/repos/tower-qa/tests/api/test_alan.py", line 184, in test_project
    factories.job_template()
  File "/Users/alancoding/Documents/repos/tower-qa/tests/lib/fixtures/factory_fixtures.py", line 199, in __call__
    return self._has_create_factory(request=self.request, **kwargs)
  File "/Users/alancoding/Documents/repos/tower-qa/tests/lib/fixtures/factory_fixtures.py", line 59, in __call__
    has_create = cls.model(connection).create(**kwargs)
  File "/Users/alancoding/Documents/tower/awxkit/awxkit/api/pages/job_templates.py", line 176, in create
    project=project, **kwargs)
  File "/Users/alancoding/Documents/tower/awxkit/awxkit/api/pages/job_templates.py", line 147, in create_payload
    Project)))
  File "/Users/alancoding/Documents/tower/awxkit/awxkit/api/mixins/has_create.py", line 360, in create_and_update_dependencies
    created = to_create(self.connection).create(**scoped_args)
  File "/Users/alancoding/Documents/tower/awxkit/awxkit/api/pages/projects.py", line 116, in create
    update.wait_until_completed().assert_successful()
  File "/Users/alancoding/Documents/tower/awxkit/awxkit/api/mixins/has_status.py", line 92, in assert_successful
    return self.assert_status('successful', msg=msg)
  File "/Users/alancoding/Documents/tower/awxkit/awxkit/api/mixins/has_status.py", line 89, in assert_status
    raise AssertionError(msg)
AssertionError: Project_Update-384 has status of error, which is not in ['successful'].
result_traceback:
Traceback (most recent call last):
  File "/awx_devel/awx/main/tasks.py", line 1275, in run
    self.pre_run_hook(self.instance, private_data_dir)
  File "/awx_devel/awx/main/tasks.py", line 2231, in pre_run_hook
    os.mkdir(settings.PROJECTS_ROOT)
FileExistsError: [Errno 17] File exists: '/var/lib/awx/projects/'

TIME WHEN STATUS WAS FOUND: 2020-02-12 14:30:24.729099 (UTC)

Under nominal conditions, this isn't expected to ever fail, unless github isn't working or the configured default project URL is bad. But that's actually a pretty good point about github, there are some things we can't control.

...but in this particular example I'm showing there, I just messed up my environment (remember those file permission errors we've had other times?). I suspect there are several cases where this will be a frustrating-reducing change.

[softwarefactory-project-zuul]

Build succeeded.

• awx-api-lint : SUCCESS in 3m 01s
• awx-api : SUCCESS in 13m 10s
• awx-ui : SUCCESS in 6m 30s
• awx-ui-next : SUCCESS in 11m 30s
• awx-swagger : SUCCESS in 12m 06s
• awx-detect-schema-change : SUCCESS in 14m 04s (non-voting)
• awx-ansible-modules : SUCCESS in 3m 13s

[ryanpetrello]

Seems reasonable to me.

[AlanCoding]

hit some turbulence getting this fully tested, will check back in later

[softwarefactory-project-zuul]

Build failed.

• awx-api-lint : SUCCESS in 10m 59s
• awx-api : SUCCESS in 23m 45s
• awx-ui : FAILURE in 8m 14s
• awx-ui-next : SUCCESS in 17m 00s
• awx-swagger : SUCCESS in 11m 16s
• awx-detect-schema-change : SUCCESS in 16m 41s (non-voting)
• awx-ansible-modules : FAILURE in 8m 08s

[softwarefactory-project-zuul]

Build failed.

• awx-api-lint : FAILURE in 10m 37s
• awx-api : SUCCESS in 18m 31s
• awx-ui : FAILURE in 14m 57s
• awx-ui-next : SUCCESS in 19m 42s
• awx-swagger : SUCCESS in 19m 30s
• awx-detect-schema-change : FAILURE in 10m 57s (non-voting)
• awx-ansible-modules : FAILURE in 10m 50s

[AlanCoding]

recheck

[softwarefactory-project-zuul]

Build succeeded.

• awx-api-lint : SUCCESS in 5m 09s
• awx-api : SUCCESS in 12m 54s
• awx-ui : SUCCESS in 6m 34s
• awx-ui-next : SUCCESS in 10m 07s
• awx-swagger : SUCCESS in 5m 45s
• awx-detect-schema-change : SUCCESS in 13m 56s (non-voting)
• awx-ansible-modules : SUCCESS in 5m 02s

[softwarefactory-project-zuul]

Build succeeded (gate pipeline).

• awx-api-lint : SUCCESS in 7m 00s
• awx-api : SUCCESS in 13m 40s
• awx-ui : SUCCESS in 8m 52s
• awx-ui-next : SUCCESS in 12m 01s
• awx-swagger : SUCCESS in 15m 39s
• awx-detect-schema-change : SUCCESS in 13m 18s (non-voting)
• awx-ansible-modules : SUCCESS in 7m 36s
• awx-push-new-schema : SUCCESS in 11m 01s (non-voting)