Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub-based npm dependencies' protocol #68

Closed
wants to merge 1 commit into from
Closed

Update GitHub-based npm dependencies' protocol #68

wants to merge 1 commit into from

Conversation

gconsidine
Copy link
Contributor

Use the syntax git+https://git@github.com/<org>/<repo> instead
of github:/<org>/<repo> to allow access to packages from envs
that can't communicate over the git protocol.

Related to #55 and #56

To try, first remove awx/ui/node_modules and then npm install from the context of awx/ui.

@gconsidine
Update GitHub-based npm dependencies' protocol
9963008 
Use the syntax `git+https://git@github.com/<org>/<repo>` instead
of `github:/<org>/<repo>` to allow access to packages from envs
that can't communicate over the git protocol.
This was referenced Sep 8, 2017
Closed
Closed
@jlmitch5
Copy link
Contributor

jlmitch5 commented Sep 8, 2017

Also link #33

jlmitch5
jlmitch5 approved these changes Sep 8, 2017
View reviewed changes
Copy link
Contributor

@jlmitch5 jlmitch5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@jlmitch5 jlmitch5 mentioned this pull request Sep 8, 2017
Closed
@gconsidine
Copy link
Contributor Author

@jlmitch5 I might cherry-pick this commit into #49 since that includes package.json and npm-shrinkwrap changes as well -- what do you think?

@gconsidine
Copy link
Contributor Author

I've added these changes to the related PR: #49

@gconsidine gconsidine closed this Sep 8, 2017
@gconsidine gconsidine deleted the ui/flexible-git-dependency-protocol branch September 8, 2017 19:50
mabashian pushed a commit to mabashian/awx that referenced this pull request Jun 28, 2019
@jakemcdermott
Merge pull request ansible#68 from ansible/refactor-nav
b375963 
replace navitem generator with expandable navgroup component
@snyk-bot snyk-bot mentioned this pull request Jul 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlmitch5 jlmitch5 jlmitch5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gconsidine @jlmitch5 @wwitzel3