Adds toast to notification template list whenever test notification finishes #9318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build succeeded.
|
nixocio
approved these changes
Feb 16, 2021
mabashian
force-pushed
the
9223-notif-toast
branch
from
527df90
to
ee78ad6
Compare
|
Build succeeded.
|
|
The tooltip looks empty: if you don't mind, could you add
|
mabashian
force-pushed
the
9223-notif-toast
branch
from
ee78ad6
to
8111863
Compare
|
Build succeeded.
|
|
Build succeeded.
|
tiagodread
approved these changes
Mar 9, 2021
|
Build succeeded (gate pipeline).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
link #9223
I decided to make the success toasts disappear on a timer but the failure toasts are sticky. This is slightly different from the UX of the old app where all toasts would disappear on a timer.
ISSUE TYPE
COMPONENT NAME