Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oauth2 provider #133

Merged
merged 46 commits into from
May 8, 2024
Merged

Oauth2 provider #133

merged 46 commits into from
May 8, 2024

Conversation

john-westcott-iv
Copy link
Member

@john-westcott-iv john-westcott-iv commented Feb 11, 2024 •
edited

Replaces #44

  • Update requirements_all.txt
  • Add common model changes to prevent time changing from oauth2 system changes
  • Add tests
  • Fix linting

@john-westcott-iv john-westcott-iv force-pushed the oauth2_provider_new branch 4 times, most recently from e4d7512 to 2586a96 Compare February 12, 2024 12:50
@john-westcott-iv john-westcott-iv force-pushed the oauth2_provider_new branch 2 times, most recently from 22a6fde to 5175a48 Compare February 28, 2024 19:41
@john-westcott-iv john-westcott-iv force-pushed the oauth2_provider_new branch 3 times, most recently from 4231acd to b56bc93 Compare April 15, 2024 19:29
@relrod relrod self-assigned this Apr 16, 2024
@relrod relrod force-pushed the oauth2_provider_new branch 5 times, most recently from e3a5793 to 5dbf5b2 Compare April 22, 2024 22:07
@relrod relrod force-pushed the oauth2_provider_new branch 4 times, most recently from c596543 to 7d35c33 Compare May 1, 2024 20:31
john-westcott-iv and others added 9 commits May 5, 2024 17:09
@john-westcott-iv @relrod
Add oauth2 provider application
206ef80
@john-westcott-iv @relrod
Start unit tests for oauth2 provider
6e33c5a
@relrod
Regen migrations for common changes
d3605ab 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Tighten up is_external_account() and fix tests
60b4cd1 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
fix import alias
90c821b 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
I regret everything.
e8f8329 
Revert "Regen migrations for common changes"

This reverts commit 53b7fb6.
@relrod
Try fixing up migrations while not squashing them
a65cc9b 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Start on application tests
e1188fb 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Port a few tests from AWX
e7dcb01 
Signed-off-by: Rick Elrod <rick@elrod.me>
relrod added 9 commits May 5, 2024 17:09
@relrod
Nix DOT updated/created fields from some models
6e70130 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Use the API for the token fixture
7bc557c 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Clean up migrations
25cef53 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Start a doc for differences from AWX
4dc5d82 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Make summary fields useful for Application
97501de 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Get /users/N/authorized_tokens/ working
96d616a 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Just hardcode the user model basename in the mixin
5c179d4 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
We can't check user actions when we add more
0370e76 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Finish porting AWX tests over
243060a 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Use CommonModel fields for created and modified
33754a2 
We have to use the right order of inheritance for this to work, and
not null out fields that we actually want :)

Signed-off-by: Rick Elrod <rick@elrod.me>
john-westcott-iv
john-westcott-iv commented May 7, 2024
View reviewed changes
ansible_base/oauth2_provider/models/application.py Show resolved Hide resolved
ansible_base/lib/serializers/common.py Show resolved Hide resolved
ansible_base/lib/utils/views/ansible_base.py Show resolved Hide resolved
ansible_base/oauth2_provider/models/access_token.py Show resolved Hide resolved
ansible_base/oauth2_provider/models/access_token.py Show resolved Hide resolved
ansible_base/oauth2_provider/serializers/application.py Show resolved Hide resolved
ansible_base/oauth2_provider/serializers/token.py Outdated Show resolved Hide resolved
ansible_base/oauth2_provider/serializers/token.py Outdated Show resolved Hide resolved
ansible_base/oauth2_provider/serializers/token.py Outdated Show resolved Hide resolved
ansible_base/oauth2_provider/views/token.py Outdated Show resolved Hide resolved
This was referenced May 8, 2024
Open
Closed
relrod added 2 commits May 8, 2024 16:10
@relrod
Nix dependency LB
3e685c3 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Use wildcard
f43a778 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod relrod mentioned this pull request May 8, 2024
Open
relrod added 7 commits May 8, 2024 16:21
@relrod
s/access/refresh/
f825464 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Fix logger path
ed14d40 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
DRY ALLOWED_SCOPES in token serializer
92c88c2 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Use crum's get_current_user()
67036fd 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Be specific because people aren't mind-readers
d8b99a2 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Use authenticator name instead of its type
c03cda6 
Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod
Just show the None if it's None
077def8 
Signed-off-by: Rick Elrod <rick@elrod.me>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 8, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@john-westcott-iv john-westcott-iv changed the title [WIP] Oauth2 provider Oauth2 provider May 8, 2024
@john-westcott-iv john-westcott-iv mentioned this pull request May 8, 2024
Open
@relrod relrod merged commit 010efea into ansible:devel May 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relrod relrod relrod left review comments

@jctanner jctanner jctanner approved these changes

Assignees

@relrod relrod

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@john-westcott-iv @relrod @jctanner