[translations] /rest_filters updates #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Technically a WIP, spoke more @AlanCoding and need to change a few more things (but everything here is good for review) |
djyasin
approved these changes
Apr 19, 2024
thedoubl3j
force-pushed
the
rest_filters_translations
branch
from
12f28e2
to
8fa4ae1
Compare
AlanCoding
reviewed
Apr 22, 2024
ansible_base/rest_filters/rest_framework/field_lookup_backend.py
Outdated
Show resolved
Hide resolved
john-westcott-iv
force-pushed
the
rest_filters_translations
branch
from
8fa4ae1
to
e3a35b5
Compare
john-westcott-iv
approved these changes
May 2, 2024
john-westcott-iv
added
Ready To Merge
and removed
comments left
|
AlanCoding
approved these changes
May 2, 2024
|
Ignore the DAB Consumers failure, I've confirmed other PRs are seeing the same errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to rest_filters dir for translation. thanks to @AlanCoding for calling out during the work on this PR for making sure we don't translate when necessary (and also syntax checking me to make sure we are actually translating all that is needed).
Testing Steps
pip freeze | grep Djangopip install Djangomkdir localedjango-admin makemessages -l esvim locale/es/LC_MESSAGES/django.po