Move the rest_filters reserved names to a setting #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relrod
approved these changes
May 10, 2024
john-westcott-iv
approved these changes
May 13, 2024
mkanoor
reviewed
May 13, 2024
AlanCoding
force-pushed
the
reserved_names
branch
from
be773f2
to
07645b9
Compare
john-westcott-iv
force-pushed
the
reserved_names
branch
from
07645b9
to
ee23482
Compare
|
thedoubl3j
pushed a commit
to thedoubl3j/django-ansible-base
that referenced
this pull request
Jun 18, 2024
My 2 cents here - this code was really just copied over from AWX. There is a process that code needs to go through in order to generalize it so that it's just abstract, for use via a library. This never happened for at least this part of rest_filters. Since it came up, I wanted to go ahead and get it done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My 2 cents here - this code was really just copied over from AWX. There is a process that code needs to go through in order to generalize it so that it's just abstract, for use via a library. This never happened for at least this part of rest_filters. Since it came up, I wanted to go ahead and get it done.