Added support for complete match on retract fact #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When retracting a fact we should be able to specify either partial or complete facts. The default is partial since events can be huge and it might not be practical to specify the whole fact. But in some cases when the event is small they might want to do a complete match, but exclude any system added keys like meta.
mkanoor
force-pushed
the
partial_retract_fact
branch
from
28f7c7c
to
e9e3ef6
Compare
mariofusco
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When retracting a fact we should be able to specify either partial or complete facts. The default is partial since events can be huge and it might not be practical to specify the whole fact. But in some cases when the event is small they might want to do a complete match, but exclude any system added keys like meta.
https://issues.redhat.com/browse/AAP-11109