DROOLS-7475 Proposed feature for ['key'] accessor #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- updated with the new jar - test using the AST JSON for drools-jpy
mkanoor
reviewed
Jun 24, 2023
| @@ -94,6 +94,55 @@ def test_assert_multiple_facts(): | |||
| my_callback2.assert_called_with(result2) | |||
|
|
|||
|
|
|||
| def test_squared_accessors(): | |||
There was a problem hiding this comment.
@tarilabs if you use the tools/convert_to_ast.py from the ansible-rulebook repo and convert the rulebook to ast format you will get the sources data included and then if we add the ast yml file to this list
drools_jpy/tests/test_ruleset.py
Line 935 in f1fade2
mkanoor
approved these changes
Jun 26, 2023
mkanoor
added a commit
to ansible/ansible-rulebook
that referenced
this pull request
Aug 3, 2023
work-in-progress as i'm volunteering to work on this e2e, so this is a quite-complete draft for the ansible-rulebook side; i'll keep posted as i will progress on drools-ansible-rulebook-integration side. EDIT: demonstrate working locally and added e2e test as requested **JIRA**: https://issues.redhat.com/browse/DROOLS-7475 **referenced Pull Requests**: * #539 * ansible/drools_jpy#50 * kiegroup/drools-ansible-rulebook-integration#56 * https://github.com/kiegroup/drools/pull/5333 * https://issues.redhat.com/browse/AAP-10738 * kiegroup/drools-ansible-rulebook-integration#65 * ansible/drools_jpy#51 --------- Co-authored-by: Madhu Kanoor <mkanoor@redhat.com> Co-authored-by: Alex <aizquier@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drools-ansible-rulebook-integration(using this version at the time of writing/raising this PR)JIRA: https://issues.redhat.com/browse/DROOLS-7475
referenced Pull Requests: