Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back the EDA_SERVER env var #133

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Add back the EDA_SERVER env var #133

merged 1 commit into from
Sep 20, 2023

Conversation

rooftopcellist
Copy link
Member

Backstory here:

But we are adding back the EDA_SERVER env var and in the future will remove EDA_PROTOCOL and EDA_HOST in the future. Count them as deprecated for now.

@rooftopcellist
Copy link
Member Author

Hold off on merging this until ansible/eda-server#412 lands.

jamestalton
jamestalton approved these changes Sep 20, 2023
View reviewed changes
Copy link

@jamestalton jamestalton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rooftopcellist rooftopcellist merged commit 92ab8f8 into ansible:main Sep 20, 2023
@kurokobo kurokobo mentioned this pull request Sep 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamestalton jamestalton jamestalton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rooftopcellist @jamestalton