Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add PATCH action for detail view OPTIONS #887

Merged
merged 5 commits into from
May 7, 2024

Conversation

Dostonbek1
Copy link
Member

@Dostonbek1 Dostonbek1 commented May 3, 2024

Changes

  • bump DAB version to 2024.5.6
  • add PATCH action for detail view OPTIONS
  • add tests for PATCH/POST actions on OPTIONS request

Background

Response from OPTIONS request on list/detail endpoints is consumed by the UI to show/hide action buttons for the logged in user. We currently support the following two scenarios:

  1. If OPTIONS request on list view contains POST action, the logged in user has permission to create new instance of this resource

Screenshot 2024-05-03 at 12 34 22 PM

  1. If OPTIONS request on detail view contains PATCH action, the logged in user has permission to edit the current object

Screenshot 2024-05-03 at 12 34 43 PM

JIRA: AAP-20725

@Dostonbek1 Dostonbek1 requested a review from a team as a code owner May 3, 2024 16:37
@Dostonbek1 Dostonbek1 mentioned this pull request May 3, 2024
@Dostonbek1 Dostonbek1 merged commit eac9708 into ansible:main May 7, 2024
3 checks passed
@Dostonbek1 Dostonbek1 deleted the update-dab-version branch May 7, 2024 01:47
jshimkus-rh pushed a commit to jshimkus-rh/eda-server that referenced this pull request May 7, 2024
* bump DAB version to 2024.5.6
* add PATCH action for detail view OPTIONS
* add tests for PATCH/POST actions on OPTIONS request

Co-authored-by: Alan Rominger <arominge@redhat.com>
jshimkus-rh pushed a commit to jshimkus-rh/eda-server that referenced this pull request May 9, 2024
* bump DAB version to 2024.5.6
* add PATCH action for detail view OPTIONS
* add tests for PATCH/POST actions on OPTIONS request

Co-authored-by: Alan Rominger <arominge@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants