Increase ansible-lint timeout #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As ansible-lint adds more checks, it is timing out for bigger collections as ansible-freeipa when running galaxy-importer on Github runners. |
No-Issue Signed-off-by: Rafael Guterres Jeffman <rjeffman@redhat.com>
rjeffman
force-pushed
the
increase_ansible_lint_timeout
branch
from
410a7f6
to
69ac284
Compare
rjeffman
added a commit
to rjeffman/ansible-freeipa
that referenced
this pull request
Jul 20, 2023
Currently, there is a hard coded timeout in galaxy-importer that prevents larger collections to execute the ansible-lint step [1]. This patch modifies the calls to ansible-lint on development tools and upstream CI to use the same arguments as galaxy-importer and disables the execution of the ansible-lint step for the Ansible's sanity test. Requested ansible-lint version for tools is also updated, as a more recent one is required. This change will not allow development using an environment using Python 2.7, due to newer ansible-lint requirements. Roles and modules tests against target nodes using Python 2.7 is still possible. [1]: ansible/galaxy-importer#231
rjeffman
added a commit
to rjeffman/ansible-freeipa
that referenced
this pull request
Jul 21, 2023
Currently, there is a hard coded timeout in galaxy-importer that prevents larger collections to execute the ansible-lint step [1]. This patch modifies the calls to ansible-lint on development tools and upstream CI to use the same arguments as galaxy-importer and disables the execution of the ansible-lint step for the Ansible's sanity test. Requested ansible-lint version for tools is also updated, as a more recent one is required. This change will not allow development using an environment using Python 2.7, due to newer ansible-lint requirements. Roles and modules tests against target nodes using Python 2.7 is still possible. [1]: ansible/galaxy-importer#231
rjeffman
added a commit
to rjeffman/ansible-freeipa
that referenced
this pull request
Sep 5, 2023
Currently, there is a hard coded timeout in galaxy-importer that prevents larger collections to execute the ansible-lint step [1]. This patch modifies the calls to ansible-lint on development tools and upstream CI to use the same arguments as galaxy-importer and disables the execution of the ansible-lint step for the Ansible's sanity test. Requested ansible-lint version for tools is also updated, as a more recent one is required. This change will not allow development using an environment using Python 2.7, due to newer ansible-lint requirements. Roles and modules tests against target nodes using Python 2.7 is still possible. [1]: ansible/galaxy-importer#231
jctanner
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No-Issue