Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EE repositories url - allow for dot in container name #1037

Merged
merged 2 commits into from
Oct 27, 2021
Merged

EE repositories url - allow for dot in container name #1037

merged 2 commits into from
Oct 27, 2021

Conversation

himdel
Copy link
Collaborator

@himdel himdel commented Oct 27, 2021

Issue AAH-1049

(Assuming these names should be allowed)

Allowing a dot in both components of a container name should fix 404s when trying to DELETE such a container...

Before:

Request URL: http://localhost:8002/api/automation-hub/_ui/v1/execution-environments/repositories/alpine684828.6764255192/
Request Method: DELETE
Status Code: 404 Not Found

After:

Request URL: http://localhost:8002/api/automation-hub/_ui/v1/execution-environments/repositories/alpine684828.6764255192/
Request Method: DELETE
Status Code: 202 Accepted

@himdel himdel added the backport-4.4 This PR should be backported to stable-4.4 (2.1) label Oct 27, 2021
@bmclaughlin
Copy link
Contributor

/retest

@himdel himdel merged commit fa690b6 into ansible:master Oct 27, 2021
@himdel himdel deleted the repositories-dot branch October 27, 2021 19:31
@patchback
Copy link

patchback bot commented Oct 27, 2021 •
edited

Backport to stable-4.4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.4/fa690b6e92e4dabd29e5c8e8969d71b0240a60f7/pr-1037

Backported as #1038

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 27, 2021
@himdel
EE repositories url - allow for dot in container name (#1037)
1b360f0 
* EE repositories url - allow for dot in container name

Issue: AAH-1049

* CHANGES

(cherry picked from commit fa690b6)
@patchback patchback bot mentioned this pull request Oct 27, 2021
Merged
himdel added a commit that referenced this pull request Oct 30, 2021
@patchback @himdel
EE repositories url - allow for dot in container name (#1037) (#1038)
27f52b3 
* EE repositories url - allow for dot in container name

Issue: AAH-1049

* CHANGES

(cherry picked from commit fa690b6)

Co-authored-by: Martin Hradil <mhradil@redhat.com>
@github-actions github-actions bot added the backported-4.4 This PR has been backported to stable-4.4 (2.1) label Oct 30, 2021
jctanner pushed a commit to jctanner/galaxy_ng that referenced this pull request Dec 1, 2021
@himdel @jctanner
EE repositories url - allow for dot in container name (ansible#1037)
0f6f8fe 
* EE repositories url - allow for dot in container name

Issue: AAH-1049

* CHANGES
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newswangerd newswangerd newswangerd approved these changes

Assignees
No one assigned
Labels
backport-4.4 This PR should be backported to stable-4.4 (2.1) backported-4.4 This PR has been backported to stable-4.4 (2.1)
Projects
None yet
Milestone
No milestone
3 participants
@himdel @bmclaughlin @newswangerd