Remove django guardian #1057

newswangerd · 2021-11-15T20:18:43Z

No description provided.

mdellweg · 2021-11-16T12:11:40Z

galaxy_ng/app/access_control/fields.py


 from rest_framework import serializers
 from rest_framework.exceptions import ValidationError

+from pulpcore.app.models.role import Role
+
+from pulpcore.app.role_util import get_perms_for_model


@bmbouter do you agree, we should have these in the plugin api?

I think so; if a plugin needs to use it and it's the right tool for the job then yes.

mdellweg · 2021-11-16T12:15:52Z

galaxy_ng/app/access_control/fields.py

            # TODO(newswangerd): Figure out how to make this one SQL query instead of
            # performing N queries for each permission


How about

missing_roles = set(roles) - set(Role.objects.filter(name__in=roles))

?

awcrosby

We do have recently added guardian piece that will need to get updated, it is run on each deploy of insights mode: https://github.com/ansible/galaxy_ng/blob/master/galaxy_ng/app/management/commands/maintain-pe-group.py

netlify · 2022-03-29T15:30:22Z

✅ Deploy Preview for galaxyng ready!

Name	Link
🔨 Latest commit	`a307740`
🔍 Latest deploy log	https://app.netlify.com/sites/galaxyng/deploys/6245f6087f24670008a5e61e
😎 Deploy Preview	https://deploy-preview-1057--galaxyng.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

- Replace get_users_with_perms - Replace get_objects_for_user Issue: AAH-1093

- Rename object_roles back to object_permissions for compatibility - Updated tests - Import Roles model from the plugin api - Remove unused settings import - subclass core.Group for Group model - Viewset shim required by pulpcore - Fix gettext CI error - Add locked roles galaxy.group_admin, galaxy.user_admin and updated galaxy.synclist_owner Issue: AAH-1093

Issue: AAH-1093

bmclaughlin · 2022-03-29T17:12:37Z

/retest

bmclaughlin · 2022-03-30T13:12:42Z

/retest

galaxy_ng/app/management/commands/maintain-pe-group.py

galaxy_ng/tests/unit/api/base.py

galaxy_ng/app/access_control/statements/roles.py

- Added galaxy.content_admin locked role - Updated integration test Issue: AAH-1093

…e-group pe_group - updated tests as needed Issue: AAH-1093

awcrosby

Updates look good, I want to do a quick check in an ephemeral env of the partner-engineering group (when the env is available). But the Jira issue should be able to proceed into QE Review.

Issue: AAH-1093

awcrosby · 2022-04-01T13:21:57Z

/retest

awcrosby · 2022-04-01T17:48:39Z

@bmclaughlin spinning up an ephemeral env and trying to create a namespace in the UI, I added a group to "Namespace owners" but the POST hit an error:

"status":"400",
"title":"Invalid input.",
"detail":"object_roles field is required",
"source":{"parameter":"groups"}

newswangerd · 2022-04-05T19:43:25Z

@bmclaughlin spinning up an ephemeral env and trying to create a namespace in the UI, I added a group to "Namespace owners" but the POST hit an error:
"status":"400",
"title":"Invalid input.",
"detail":"object_roles field is required",
"source":{"parameter":"groups"}

@awcrosby the UI still needs to be updated to work with these changes. We've had to make some breaking changes to this api by removing the ability to add permissions to group/object combinations, since that's no longer supported by pulpcore.

Brian fixed andrews changes and andrew is out sick and can't approve the pr

…ding group to namespace breaks after ansible/galaxy_ng#1057

This reverts commit d84dee6.

* Revert "Remove django guardian (#1057)". This reverts commit d84dee6. * Revert "Create galaxy_ng specific Roles (#1058)". This reverts commit 3fefab0. No-Issue

…ding group to namespace breaks after ansible/galaxy_ng#1057

…ect_roles, not object_permissions (#39) * gitignore vim swapfiles * namespaces.addgroup - use object_roles, not object_permissions no object_permissions since ansible/galaxy_ng#1057 * galaxykit groups & roles - add roles, move perms to roles ```diff +galaxykit group role * +galaxykit role * -galaxykit group perm * +galaxykit role perm * ``` * remove client.set_permissions (not sure if unused, or if we just need to change it to call roles.set_permissions instead of groups.set_permissions) * fix regex typo * galaxykit role create: add -p alias for --permissions

newswangerd marked this pull request as draft November 15, 2021 20:18

newswangerd mentioned this pull request Nov 15, 2021

Rest interface to manage roles on objects pulp/pulpcore#1693

Merged

mdellweg reviewed Nov 16, 2021

View reviewed changes

bmclaughlin force-pushed the fix/AAH-1093-remove-django-guardian branch from 645d08c to f487da3 Compare January 14, 2022 15:27

bmclaughlin force-pushed the fix/AAH-1093-remove-django-guardian branch from 7f66c47 to ced1f82 Compare February 14, 2022 23:47

bmclaughlin force-pushed the fix/AAH-1093-remove-django-guardian branch 5 times, most recently from 9c0df23 to 294afcd Compare March 18, 2022 18:27

bmclaughlin marked this pull request as ready for review March 18, 2022 18:46

bmclaughlin requested review from rochacbruno and awcrosby March 18, 2022 19:32

bmclaughlin changed the title ~~[WIP] Remove django guardian~~ Remove django guardian Mar 22, 2022

rochacbruno approved these changes Mar 23, 2022

View reviewed changes

awcrosby suggested changes Mar 25, 2022

View reviewed changes

bmclaughlin force-pushed the fix/AAH-1093-remove-django-guardian branch from 294afcd to 19eb37c Compare March 29, 2022 15:30

newswangerd and others added 3 commits March 29, 2022 11:32

- Fix role assignment

1964118

- Replace get_users_with_perms - Replace get_objects_for_user Issue: AAH-1093

Update pe group management command

d123723

Issue: AAH-1093

bmclaughlin force-pushed the fix/AAH-1093-remove-django-guardian branch from 19eb37c to d123723 Compare March 29, 2022 15:33

bmclaughlin requested a review from awcrosby March 29, 2022 18:43

awcrosby previously requested changes Mar 30, 2022

View reviewed changes

galaxy_ng/app/management/commands/maintain-pe-group.py Outdated Show resolved Hide resolved

galaxy_ng/tests/unit/api/base.py Show resolved Hide resolved

awcrosby reviewed Mar 30, 2022

View reviewed changes

galaxy_ng/app/access_control/statements/roles.py Show resolved Hide resolved

bmclaughlin force-pushed the fix/AAH-1093-remove-django-guardian branch from 526c89d to f853794 Compare March 30, 2022 20:15

- Updated pe group management command

2cb3e6c

- Added galaxy.content_admin locked role - Updated integration test Issue: AAH-1093

bmclaughlin force-pushed the fix/AAH-1093-remove-django-guardian branch from f853794 to 2cb3e6c Compare March 30, 2022 20:21

Make unit test pe_group consistent with management command maintain-p…

f2097ca

…e-group pe_group - updated tests as needed Issue: AAH-1093

bmclaughlin requested a review from awcrosby March 31, 2022 14:19

awcrosby reviewed Mar 31, 2022

View reviewed changes

Remove print statements

a307740

Issue: AAH-1093

bmclaughlin requested a review from chr-stian April 6, 2022 14:12

newswangerd requested a review from awcrosby April 7, 2022 12:19

bmclaughlin approved these changes Apr 7, 2022

View reviewed changes

newswangerd merged commit d84dee6 into ansible:master Apr 7, 2022

himdel mentioned this pull request Apr 7, 2022

collection_upload test - fix sporadic failure ansible/ansible-hub-ui#1862

Merged

sean-m-sullivan mentioned this pull request Apr 7, 2022

Update group perms module ansible/galaxy_collection#78

Closed

himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Apr 8, 2022

namespaces.js test - skip test depending on being in a group, skip ad…

c4cc745

…ding group to namespace breaks after ansible/galaxy_ng#1057

This was referenced Apr 8, 2022

feature/rbac-roles - add role commands; namespaces.addgroup - use object_roles, not object_permissions ansible/galaxykit#39

Merged

[rbac] New UI for object permission assignment ansible/ansible-hub-ui#1863

Merged

himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Apr 8, 2022

namespaces.js test - skip test depending on being in a group, skip ad…

470a13b

…ding group to namespace breaks after ansible/galaxy_ng#1057

newswangerd added a commit to newswangerd/galaxy_ng that referenced this pull request Apr 11, 2022

Revert "Remove django guardian (ansible#1057)"

8c4d178

This reverts commit d84dee6.

newswangerd added a commit that referenced this pull request Apr 11, 2022

Revert RBAC Roles (#1205)

67dbd31

* Revert "Remove django guardian (#1057)". This reverts commit d84dee6. * Revert "Create galaxy_ng specific Roles (#1058)". This reverts commit 3fefab0. No-Issue

himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Apr 25, 2022

namespaces.js test - skip test depending on being in a group, skip ad…

798a530

…ding group to namespace breaks after ansible/galaxy_ng#1057

himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Apr 26, 2022

namespaces.js test - skip test depending on being in a group, skip ad…

aa150c0

…ding group to namespace breaks after ansible/galaxy_ng#1057

himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Apr 26, 2022

namespaces.js test - skip test depending on being in a group, skip ad…

9aefa85

…ding group to namespace breaks after ansible/galaxy_ng#1057

himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Apr 26, 2022

namespaces.js test - skip test depending on being in a group, skip ad…

8f5d252

…ding group to namespace breaks after ansible/galaxy_ng#1057

himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Apr 26, 2022

namespaces.js test - skip test depending on being in a group, skip ad…

30489d0

…ding group to namespace breaks after ansible/galaxy_ng#1057

himdel added a commit to himdel/ansible-hub-ui that referenced this pull request Apr 26, 2022

namespaces.js test - skip test depending on being in a group, skip ad…

20f6b84

…ding group to namespace breaks after ansible/galaxy_ng#1057

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove django guardian #1057

Remove django guardian #1057

newswangerd commented Nov 15, 2021

mdellweg Nov 16, 2021

bmbouter Nov 16, 2021

mdellweg Nov 16, 2021

awcrosby left a comment

netlify bot commented Mar 29, 2022 •

edited

bmclaughlin commented Mar 29, 2022

bmclaughlin commented Mar 30, 2022

awcrosby left a comment

awcrosby commented Apr 1, 2022

awcrosby commented Apr 1, 2022

newswangerd commented Apr 5, 2022

		# TODO(newswangerd): Figure out how to make this one SQL query instead of
		# performing N queries for each permission

Remove django guardian #1057

Remove django guardian #1057

Conversation

newswangerd commented Nov 15, 2021

mdellweg Nov 16, 2021

Choose a reason for hiding this comment

bmbouter Nov 16, 2021

Choose a reason for hiding this comment

mdellweg Nov 16, 2021

Choose a reason for hiding this comment

awcrosby left a comment

Choose a reason for hiding this comment

netlify bot commented Mar 29, 2022 • edited

✅ Deploy Preview for galaxyng ready!

bmclaughlin commented Mar 29, 2022

bmclaughlin commented Mar 30, 2022

awcrosby left a comment

Choose a reason for hiding this comment

awcrosby commented Apr 1, 2022

awcrosby commented Apr 1, 2022

newswangerd commented Apr 5, 2022

netlify bot commented Mar 29, 2022 •

edited