Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename permissions_assignment to creation_hooks #1096

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Rename permissions_assignment to creation_hooks #1096

merged 1 commit into from
Jan 26, 2022

Conversation

fao89
Copy link
Contributor

@fao89 fao89 commented Jan 10, 2022

@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@awcrosby
Copy link
Contributor

/retest

@fao89 fao89 requested review from a team, awcrosby and bmclaughlin January 13, 2022 17:48
bmbouter
bmbouter reviewed Jan 14, 2022
View reviewed changes
Copy link

@bmbouter bmbouter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me. @mdellweg wdyt?

@fao89
Copy link
Contributor Author

fao89 commented Jan 26, 2022

Could it be merged?

@rochacbruno
Copy link
Member

2 approvals I am going yo merge

@rochacbruno rochacbruno merged commit ea84735 into ansible:master Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmbouter bmbouter bmbouter left review comments

@bmclaughlin bmclaughlin bmclaughlin approved these changes

@awcrosby awcrosby awcrosby approved these changes

@mdellweg mdellweg mdellweg approved these changes

@newswangerd newswangerd Awaiting requested review from newswangerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
7 participants
@fao89 @app-sre-bot @awcrosby @rochacbruno @bmbouter @bmclaughlin @mdellweg