Update CI #1106
Merged
Update CI #1106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
fao89
commented
Jan 26, 2022
template_config.yml
Outdated
| @@ -85,11 +86,13 @@ tasking_allow_async_unsafe: true | |||
| test_azure: true | |||
| test_bindings: false | |||
| test_cli: false | |||
| test_deprecations: true | |||
There was a problem hiding this comment.
PR fails because we are testing pulpcore deprecations
There was a problem hiding this comment.
@fao89 should we keep testing it? or change to false in this PR?
There was a problem hiding this comment.
I don't know, it is up to galaxy
I personally think this deprecation test could be moved to your nightly latest
fao89
commented
Jan 26, 2022
| @@ -1,4 +1,4 @@ | |||
| FROM {{ ci_base | default("pulp/pulp-ci-centos:" + pulp_container_tag) }} | |||
| FROM {{ ci_base | default("ghcr.io/pulp/pulp-ci-centos:" + pulp_container_tag) }} | |||
There was a problem hiding this comment.
this was my main motivator for this PR, use github container registry instead of docker
rochacbruno
approved these changes
Jan 27, 2022
|
/retest |
|
could you please merge? |
5 tasks
bmclaughlin
added a commit
to bmclaughlin/galaxy_ng
that referenced
this pull request
Feb 1, 2022
Issue: AAH-1243 Issue: AAH-1202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed CI update workflow is broken: https://github.com/ansible/galaxy_ng/actions/workflows/update_ci.yml
So I manually update it from plugin-template