Combine the copy and remove tasks #1122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awcrosby
force-pushed
the
fix/combine_tasks_copy_remove
branch
from
9b180b2
to
90cfdb4
Compare
|
@rochacbruno I still have a unit test I want to update but this is ready for review. I am hoping you can include the signature pieces in the |
awcrosby
added
backport-4.3
rochacbruno
approved these changes
Feb 10, 2022
Ensure copy and remove tasks are run in sequence by combining from 2 tasks into 1, where they share the same locks. Avoids scenario where 1 task can fail and the other can succeed. Issue: AAH-1349
awcrosby
force-pushed
the
fix/combine_tasks_copy_remove
branch
from
8f98032
to
5c41f4c
Compare
awcrosby
added a commit
to awcrosby/galaxy_ng
that referenced
this pull request
Feb 11, 2022
Ensure copy and remove tasks are run in sequence by combining from 2 tasks into 1, where they share the same locks. Avoids scenario where 1 task can fail and the other can succeed. Issue: AAH-1349 (cherry picked from commit 0608454)
awcrosby
added a commit
to awcrosby/galaxy_ng
that referenced
this pull request
Mar 15, 2022
Ensure copy and remove tasks are run in sequence by combining from 2 tasks into 1, where they share the same locks. Avoids scenario where 1 task can fail and the other can succeed. Issue: AAH-1349 (cherry picked from commit 0608454)
awcrosby
added a commit
that referenced
this pull request
Mar 17, 2022
github-actions
bot
added
the
backported-4.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 🛠
For copying and removing content from a repository, currently 2 tasks
are called. Changing to be 1 task so lock and transaction can occur in
a single task. Pulls work done by @rochacbruno from #1076.
Issue: AAH-1349
Reviewer Checklists 👀
Developer reviewer:
galaxy_ng/tests/integrationorgalaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not neededQE reviewer (exceptions):
galaxy_ng/tests/integrationorgalaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not neededNote: when merging, include the Jira issue link in the squashed commit