Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add landing page endpoint for the console redhat #1130

Merged
merged 2 commits into from
Feb 25, 2022
Merged

Add landing page endpoint for the console redhat #1130

merged 2 commits into from
Feb 25, 2022

Conversation

brumik
Copy link
Contributor

@brumik brumik commented Feb 14, 2022

Issue: AAH-1278

This commit adds the endpoints for the landing page on the console.redhat.com. It is going to be a self service so all
the dynamic data should be prefilled: collection and partner in the current case.

Next after this is deployed to STAGE by this document

  • I'll contact the platform to add this endpoint to chrome
  • After they add the endpoint QE can verify the looks and data displayed on STAGE

The currently used schema is here: https://github.com/RedHatInsights/landing-page-frontend/blob/b1f358352916f3f6b4813e9cfe0b4a7765005109/src/contentApi/ansible-api.js#L500

The expected prefilled format example: https://github.com/RedHatInsights/landing-page-frontend/blob/master/docs/exmple-schema.md

@brumik brumik requested review from himdel and newswangerd and removed request for himdel February 14, 2022 10:58
Copy link
Member

@newswangerd newswangerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python code looks pretty good overall. Added some comments about the data that's being returned as well as some improvements to the view code.

galaxy_ng/app/api/ui/views/landing_page.py Outdated Show resolved Hide resolved
galaxy_ng/app/api/ui/views/landing_page.py Outdated Show resolved Hide resolved
galaxy_ng/app/api/ui/views/landing_page.py Outdated Show resolved Hide resolved
galaxy_ng/app/api/ui/views/landing_page.py Outdated Show resolved Hide resolved
galaxy_ng/app/api/ui/views/landing_page.py Outdated Show resolved Hide resolved
galaxy_ng/app/api/ui/views/landing_page.py Outdated Show resolved Hide resolved
galaxy_ng/app/api/ui/views/landing_page.py Outdated Show resolved Hide resolved
galaxy_ng/app/api/ui/views/landing_page.py Outdated Show resolved Hide resolved
galaxy_ng/app/api/ui/views/landing_page.py Outdated Show resolved Hide resolved
galaxy_ng/app/api/ui/views/landing_page.py Outdated Show resolved Hide resolved
Issue: AAH-1278

This commit andds the endpoints for the landing page on the
console.redhat.com. It is going to be a self service so all
the dynamic data should be prefilled: collection and partner
count in the current case.
@brumik
Copy link
Contributor Author

brumik commented Feb 25, 2022

/retest

@newswangerd newswangerd merged commit 6a9757b into ansible:master Feb 25, 2022
awcrosby pushed a commit that referenced this pull request Feb 28, 2022
* Add landing page endpoint for the console.redhat

Issue: AAH-1278

This commit andds the endpoints for the landing page on the
console.redhat.com. It is going to be a self service so all
the dynamic data should be prefilled: collection and partner
count in the current case.

* Add integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants