Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud: add post deploy tests template #1133

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

drodowic
Copy link
Collaborator

@drodowic drodowic commented Feb 15, 2022

Issue: AAH-1212

Description 🛠

Add job template to be referenced by the post-deploy-test.yml saas file, which will run the job after a successful deploy to the stage environment.

Reviewer Checklists 👀

Developer reviewer:

  • Code looks sound, good architectural decisions, no code smells
  • There is a Jira issue associated (note that "No-Issue" should be rarely used)
  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed

QE reviewer (exceptions):

  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed
  • PR meets applicable Acceptance Criteria for associated Jira issue

Note: when merging, include the Jira issue link in the squashed commit

@hendersonreed
Copy link
Contributor

Very cool! I have a few questions about how exactly this works to authenticate with the stage environment - is this running anywhere yet, or still in-progress?

@drodowic
Copy link
Collaborator Author

Very cool! I have a few questions about how exactly this works to authenticate with the stage environment - is this running anywhere yet, or still in-progress?

It is not running yet, here is the app-interface MR that will utilize this template to create the job pod. Also any secrets required, such as the one currently reference by IQE_TESTS_LOCAL_CONF_PATH will have to be added to Vault.

@jameswnl
Copy link

@drodowic there's a bug in app-interface, you need to add a JOBID to the image to over come that. You can refer to https://gitlab.cee.redhat.com/automation-analytics/automation-analytics-backend/-/merge_requests/313/diffs

And app-interface issue is https://issues.redhat.com/browse/APPSRE-3528

@jameswnl
Copy link

@hendersonreed or @awcrosby can you approve this?
This PR will not bother with any production.

@drodowic drodowic merged commit 8060b7e into ansible:master Feb 17, 2022
@drodowic drodowic deleted the clowder-test branch February 17, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants