Prevent artifact removal from latest repo version when deleting images

[bmclaughlin]

Description 🛠

Prevent artifact removal from latest repo version when deleting images
Issue: AAH-1389

Reviewer Checklists 👀

Developer reviewer:

• Code looks sound, good architectural decisions, no code smells
• There is a Jira issue associated (note that "No-Issue" should be rarely used)
• Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed

QE reviewer (exceptions):

• Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed
• PR meets applicable Acceptance Criteria for associated Jira issue

Note: when merging, include the Jira issue link in the squashed commit

[bmclaughlin]

/retest

[patchback]

Backport to stable-4.4: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 947e7d3 on top of patchback/backports/stable-4.4/947e7d38a429c314da05f675742b5671506515d7/pr-1139

Backporting merged PR #1139 into master

1. Ensure you have a local repo clone of your fork. Unless you cloned it
   from the upstream, this would be your origin remote.
2. Make sure you have an upstream repo added as a remote too. In these
   instructions you'll refer to it by the name upstream. If you don't
   have it, here's how you can add it:

   $ git remote add upstream https://github.com/ansible/galaxy_ng.git

3. Ensure you have the latest copy of upstream and prepare a branch
   that will hold the backported code:

   $ git fetch upstream
   $ git checkout -b patchback/backports/stable-4.4/947e7d38a429c314da05f675742b5671506515d7/pr-1139 upstream/stable-4.4

4. Now, cherry-pick PR Prevent artifact removal from latest repo version when deleting images #1139 contents into that branch:

   $ git cherry-pick -x 947e7d38a429c314da05f675742b5671506515d7

   If it'll yell at you with something like fatal: Commit 947e7d38a429c314da05f675742b5671506515d7 is a merge but no -m option was given., add -m 1 as follows intead:

   $ git cherry-pick -m1 -x 947e7d38a429c314da05f675742b5671506515d7

5. At this point, you'll probably encounter some merge conflicts. You must
   resolve them in to preserve the patch from PR Prevent artifact removal from latest repo version when deleting images #1139 as close to the
   original as possible.
6. Push this branch to your fork on GitHub:

   $ git push origin patchback/backports/stable-4.4/947e7d38a429c314da05f675742b5671506515d7/pr-1139

7. Create a PR, ensure that the CI is green. If it's not — update it so that
   the tests and any other checks pass. This is it!
   Now relax and wait for the maintainers to process your pull request
   when they have some cycles to do reviews. Don't worry — they'll tell you if
   any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.