Do not update Repository attributes on delete, add docs #1144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 🛠
Stop updating Repository.retain_repo_versions on delete task, so that if
retain_repo_versions has been manually set, the system will not
override.
Update tasks/deletion.py module docs to describe Content removal vs.
deletion and how retain_repo_versions is related.
No-Issue
Reviewer Checklists 👀
Developer reviewer:
galaxy_ng/tests/integration
orgalaxy_ng/tests/functional
, and they fully cover necessary test scenarios… or tests not neededQE reviewer (exceptions):
galaxy_ng/tests/integration
orgalaxy_ng/tests/functional
, and they fully cover necessary test scenarios… or tests not neededNote: when merging, include the Jira issue link in the squashed commit