Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not update Repository attributes on delete, add docs #1144

Merged
merged 1 commit into from
Mar 1, 2022

Conversation

awcrosby
Copy link
Contributor

Description 🛠

Stop updating Repository.retain_repo_versions on delete task, so that if
retain_repo_versions has been manually set, the system will not
override.

Update tasks/deletion.py module docs to describe Content removal vs.
deletion and how retain_repo_versions is related.

No-Issue

Reviewer Checklists 👀

Developer reviewer:

  • Code looks sound, good architectural decisions, no code smells
  • There is a Jira issue associated (note that "No-Issue" should be rarely used)
  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed

QE reviewer (exceptions):

  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed
  • PR meets applicable Acceptance Criteria for associated Jira issue

Note: when merging, include the Jira issue link in the squashed commit

Stop updating Repository.retain_repo_versions on delete task, so that if
retain_repo_versions has been manually set, the system will not
override.

Update tasks/deletion.py module docs to describe Content removal vs.
deletion and how retain_repo_versions is related.

No-Issue
@awcrosby awcrosby merged commit 666b9bf into ansible:master Mar 1, 2022
@awcrosby awcrosby deleted the feature/update_delete_logic branch March 1, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants