Add pulp plugin template check script and make target #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
jctanner
force-pushed
the
CI_CHECK_PULP_TEMPLATE
branch
from
ed960f6
to
b320fac
Compare
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
awcrosby
reviewed
Mar 1, 2022
|
|
||
| echo "Results ..." | ||
| cd $BASEDIR/galaxy_ng | ||
| MODIFIED_FILES=$(git status 2>/dev/null | grep 'modified:' | awk '{print $2}') |
There was a problem hiding this comment.
Which does this check for?
- PR edits file X, and
plugin-templateedits same file X - PR edits code unrelated to CI, and
plugin-templateedits any file
There was a problem hiding this comment.
oh nvm i see, this checks out the current $PLUGIN_GIT_REF
awcrosby
approved these changes
Mar 1, 2022
rochacbruno
reviewed
Mar 1, 2022
| MODIFIED_FILES=$(git status 2>/dev/null | grep 'modified:' | awk '{print $2}') | ||
| EXIT_CODE=0 | ||
| for MF in $MODIFIED_FILES; do | ||
| echo "FAILURE template-plugin would modifiy $BASEDIR/galaxy_ng/$MF" |
There was a problem hiding this comment.
So this will also fail when we run plugin_template to explicitly modify the files? how is this script differentiating when we really want to have the files edited by the template engine from when we do that by mistake?
There was a problem hiding this comment.
it looks like this passes in that case, since it checks out the current $PLUGIN_GIT_REF listed in our repo. it validates the plugin_template ref matches all the files in our repo (they are un-edited)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 🛠
Sending a PR, getting all the tests to pass, waiting for reviews, and then being told you might have edited a file that some third party repo script is going to overwrite when the dependencies for this repo are updated ... is highly annoying.
Reviewer Checklists 👀
Developer reviewer:
galaxy_ng/tests/integrationorgalaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not neededQE reviewer (exceptions):
galaxy_ng/tests/integrationorgalaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not neededNote: when merging, include the Jira issue link in the squashed commit