Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clowder: parameterize ENABLE_SIGNING and GNUPGHOME #1157

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

drodowic
Copy link
Collaborator

@drodowic drodowic commented Mar 2, 2022

No-issue

Description 🛠

parameterize ENABLE_SIGNING and GNUPGHOME envvars in the clowder config to allow ephemeral to be deployed differently from stage and prod

Reviewer Checklists 👀

Developer reviewer:

  • Code looks sound, good architectural decisions, no code smells
  • There is a Jira issue associated (note that "No-Issue" should be rarely used)
  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed

QE reviewer (exceptions):

  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed
  • PR meets applicable Acceptance Criteria for associated Jira issue

Note: when merging, include the Jira issue link in the squashed commit

@rochacbruno rochacbruno merged commit dee92ad into ansible:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants