Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check commit signatures #1164

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Conversation

jctanner
Copy link
Contributor

@jctanner jctanner commented Mar 7, 2022

Description 🛠

Signatures are required on all commits, but we're not enforcing it via any known mechanism other than hoping it's caught by human review.

Reviewer Checklists 👀

Developer reviewer:

  • Code looks sound, good architectural decisions, no code smells
  • There is a Jira issue associated (note that "No-Issue" should be rarely used)
  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed

QE reviewer (exceptions):

  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed
  • PR meets applicable Acceptance Criteria for associated Jira issue

Note: when merging, include the Jira issue link in the squashed commit

No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
@mdellweg
Copy link

mdellweg commented Mar 8, 2022

You know you can configure that in GH branch protection rules?

@rochacbruno
Copy link
Member

rochacbruno commented Mar 8, 2022

@mdellweg it is already checked but that config prevents merges to the specific branch eg: master the developer will not be notified about it, it will only prevent the merge, and it would be useful to have this check to notify the developer during PR check.
Screenshot_2022-03-08_15-16-56

No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
@newswangerd newswangerd merged commit 7dc21e7 into ansible:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants