Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove customadmin #1184

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Remove customadmin #1184

merged 1 commit into from
Mar 29, 2022

Conversation

rochacbruno
Copy link
Member

@rochacbruno rochacbruno commented Mar 24, 2022

Issue: AAH-1478

Description 🛠

Add PR description here

Reviewer Checklists 👀

Developer reviewer:

  • Code looks sound, good architectural decisions, no code smells
  • There is a Jira issue associated (note that "No-Issue" should be rarely used)
  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed

QE reviewer (exceptions):

  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed
  • PR meets applicable Acceptance Criteria for associated Jira issue

Note: when merging, include the Jira issue link in the squashed commit

@netlify
Copy link

netlify bot commented Mar 24, 2022

Deploy Preview for galaxyng ready!

Name Link
🔨 Latest commit 85a1ed0
🔍 Latest deploy log https://app.netlify.com/sites/galaxyng/deploys/62418de04ec0290009a2f461
😎 Deploy Preview https://deploy-preview-1184--galaxyng.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@fao89 fao89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I feel it needs a changelog entry

@fao89 fao89 requested a review from bmbouter March 24, 2022 20:34
@fao89
Copy link
Contributor

fao89 commented Mar 24, 2022

Related to pulp/pulpcore#2378

@bmbouter
Copy link

👍 to this, this was never a safe tool for Pulp, and if you need to do things the CLI can do it much better.

Issue: AAH-1478
@newswangerd newswangerd merged commit b37dbf6 into ansible:master Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants