Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] Filtering by multiple Q() expressions is too slow on Django … #1190

Merged
merged 3 commits into from
Mar 31, 2022

Conversation

rochacbruno
Copy link
Member

@rochacbruno rochacbruno commented Mar 29, 2022

…filter.

Solved by replacing with annotations.

Issue: AAH-1484

On a 2803 CollectionVersion queryset

galaxy_ng-api-1          | base_versions_query query time: 0.0081s
galaxy_ng-api-1          | collection_versions dict build time: 0.0521s
galaxy_ng-api-1          | deprecated_query query time: 0.0014s
galaxy_ng-api-1          | Main version_qs query time: 0.0000s
galaxy_ng-api-1          | version_qs annotate time: 0.0031s
galaxy_ng-api-1          | version_qs filter time: 0.0049s

Description 🛠

Add PR description here

Reviewer Checklists 👀

Developer reviewer:

  • Code looks sound, good architectural decisions, no code smells
  • There is a Jira issue associated (note that "No-Issue" should be rarely used)
  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed

QE reviewer (exceptions):

  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed
  • PR meets applicable Acceptance Criteria for associated Jira issue

Note: when merging, include the Jira issue link in the squashed commit

@netlify
Copy link

netlify bot commented Mar 29, 2022

Deploy Preview for galaxyng ready!

Name Link
🔨 Latest commit 55e0a77
🔍 Latest deploy log https://app.netlify.com/sites/galaxyng/deploys/62435410afd154000861c904
😎 Deploy Preview https://deploy-preview-1190--galaxyng.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

…filter.

Solved by replacing with annotations.

Issue: AAH-1484
@rochacbruno
Copy link
Member Author

/retest

3 similar comments
@awcrosby
Copy link
Contributor

/retest

@awcrosby
Copy link
Contributor

/retest

@awcrosby
Copy link
Contributor

/retest

@awcrosby awcrosby merged commit 0ffba2e into ansible:master Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants