Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force the compose script to exit if the checkout path is wrong #1208

Merged
merged 1 commit into from
Apr 12, 2022

Conversation

jctanner
Copy link
Contributor

Description 🛠

entrypoint.sh makes assumptions about the checkout path inside the volume mounts. If the underlying host galaxy_ng checkout is not named "galaxy_ng" (galaxy_ng.foobar for example) but you also have a folder named "galaxy_ng", the script will not use the galaxy_ng.foobar folder for pip installs. That makes it seem like your code edits aren't being reflected inside the containers and it's not very obvious why.

Reviewer Checklists 👀

Developer reviewer:

  • Code looks sound, good architectural decisions, no code smells
  • There is a Jira issue associated (note that "No-Issue" should be rarely used)
  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed

QE reviewer (exceptions):

  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed
  • PR meets applicable Acceptance Criteria for associated Jira issue

Note: when merging, include the Jira issue link in the squashed commit

…cted name

No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
@netlify
Copy link

netlify bot commented Apr 12, 2022

Deploy Preview for galaxyng ready!

Name Link
🔨 Latest commit a3a5b50
🔍 Latest deploy log https://app.netlify.com/sites/galaxyng/deploys/625597bafe5b700008d6ba92
😎 Deploy Preview https://deploy-preview-1208--galaxyng.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@himdel
Copy link
Collaborator

himdel commented Apr 12, 2022

What are the unintended behaviours? (description)

I'm using galaxy_ng for master, and galaxy_ng-4.2 through galaxy_ng-4.4 for dealing with the stable versions. (I guess I won't anymore :))

EDIT: plugin-template generation seems to write to galaxy_ng-4.3 just fine .. but reads jinja templates from galaxy_ng regardless.

@awcrosby
Copy link
Contributor

https://ci.int.devshift.net/job/ansible-galaxy_ng-pr-check/687/ has passed, so all CI jobs passing

@newswangerd newswangerd merged commit 8a15406 into ansible:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants