Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #1238/6e8148b7 backport][stable-4.5] Ensure that container remotes exclude source images by default. #1243

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented May 3, 2022

This is a backport of PR #1238 as merged into master (6e8148b).

Issue: AAH-1557

Description 🛠

Fixes: https://issues.redhat.com/browse/AAH-1557

This makes it so that all new container remotes exclude image tags matching "*-source" by default.

Reviewer Checklists 👀

Developer reviewer:

  • Code looks sound, good architectural decisions, no code smells
  • There is a Jira issue associated (note that "No-Issue" should be rarely used)
  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed

QE reviewer (exceptions):

  • Tests are included in galaxy_ng/tests/integration or galaxy_ng/tests/functional, and they fully cover necessary test scenarios… or tests not needed
  • PR meets applicable Acceptance Criteria for associated Jira issue

Note: when merging, include the Jira issue link in the squashed commit

* Ensure that container remotes exclude source images by default.

Issue: AAH-1557

* Flake8

(cherry picked from commit 6e8148b)
@newswangerd newswangerd merged commit 14ef32a into stable-4.5 May 4, 2022
@newswangerd newswangerd deleted the patchback/backports/stable-4.5/6e8148b71dc2ea6c14658581166474e93c44e8b5/pr-1238 branch May 4, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant