[beta] v1 legacy roles MVP #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for galaxyng ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
/retest |
3 similar comments
|
/retest |
|
/retest |
|
/retest |
awcrosby
reviewed
Aug 17, 2022
awcrosby
reviewed
Aug 17, 2022
awcrosby
reviewed
Aug 18, 2022
awcrosby
reviewed
Aug 18, 2022
newswangerd
requested changes
Aug 18, 2022
awcrosby
reviewed
Aug 18, 2022
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
newswangerd
requested changes
Sep 1, 2022
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
No-Issue Signed-off-by: James Tanner <tanner.jc@gmail.com>
newswangerd
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
A couple of minor nitpicks, no deal breakers.
Before this goes into production I do want to see:
- A proper RBAC implementation for legacy namespace
- Replacement for the
username==legacy_namespace.namelogic to determine if a user owns a namespace - Some kind of system to migrate the existing users from galaxy into galaxy_ng so we don't have to rely on the user's github username matching one of the namespaces
| permission_classes = [LegacyAccessPolicy] | ||
| authentication_classes = GALAXY_AUTHENTICATION_CLASSES | ||
|
|
||
| def destroy(self, request, pk=None): |
There was a problem hiding this comment.
I think the default DRF method should work for this
| """A list of legacy roles.""" | ||
|
|
||
| queryset = LegacyRole.objects.all().order_by('full_metadata__created') | ||
| ordering_fields = ('full_metadata__created') |
There was a problem hiding this comment.
do you need to order this in 3 places?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing:
Issue: AAH-1812
Reviewers must know:
Notes:
PR Author: Add a QE reviewer (exceptions);
Reviewers: look for sound code, no code smells, docs & test coverage
Merger: When merging, include the Jira issue link in the squashed commit