Adds an ee_admin user to test setup #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for galaxyng ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Replaces admin user use with ee_admin user Issue: AAH-1796
bmclaughlin
force-pushed
the
AAH-1796-add-ee-admin-to-tests
branch
from
30903c3
to
dcae542
Compare
awcrosby
suggested changes
Aug 19, 2022
Comment on lines
100
to
101
| "ee_admin": { | ||
| "username": "ee-admin", |
There was a problem hiding this comment.
you can probably make these both ee_admin ... the only reason some usernames have a dash is due to their setup in keycloak
dev/common/setup_test_data.py
Outdated
Comment on lines
64
to
68
| # Note: this user is not a part of ephemeral keycloak users | ||
| ee_admin, _ = User.objects.get_or_create(username="ee-admin") | ||
| ee_admin.set_password("redhat") | ||
| ee_admin.groups.add(ee_group) | ||
| ee_admin.save() |
There was a problem hiding this comment.
If we ever need a new test user that will also be tested in insights mode, we will want to pick a username that is already in keycloak so the test users are consistent in standalone and insights mode. For this execution environment user, I think it is ok to not match up to keycloak.
Issue: AAH-1796
awcrosby
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing:
Creates an
ee_adminuser to be used in integration tests. Replaces the use of theadminuser in thetest_api_ui_v1_execution_environments_registriestest per the TODO item.Issue: AAH-1796
Reviewers must know:
Notes:
PR Author: Add a QE reviewer (exceptions);
Reviewers: look for sound code, no code smells, docs & test coverage
Merger: When merging, include the Jira issue link in the squashed commit