-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inject context to filter signatures based on distro.repository #1465
Conversation
✅ Deploy Preview for galaxyng ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
71d0df3
to
3aa56a5
Compare
3aa56a5
to
b485718
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like for testing you need a CollectionVersion in multiple repos. It would be nice to copy a collection from repo1 to repo2 and then sign in only repo1, but we don't have an endpoint for copying right now.
If you call collection-version-move
to move an already signed collection from repo1 to repo2, will the signature get moved with it? (if not, then you could check the content shows as signed only when in repo1)
Not sure if a unit test would be sufficient, but we have the ability to call add_and_remove
like this:
add_and_remove( |
bc6a88c
to
4fef418
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one possible edit
Issue: AAH-1941
Backport to stable-4.5: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply b1743a6 on top of patchback/backports/stable-4.5/b1743a68d560ff8d4d84c5ee34aa9fa3979a0da4/pr-1465 Backporting merged PR #1465 into master
🤖 @patchback |
Backport to stable-4.6: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply b1743a6 on top of patchback/backports/stable-4.6/b1743a68d560ff8d4d84c5ee34aa9fa3979a0da4/pr-1465 Backporting merged PR #1465 into master
🤖 @patchback |
Issue: AAH-1941
What is this PR doing:
Filtering signatures by distro.repository coming from context["request"]
Reviewers must know:
affects:
http://0.0.0.0:5001/api/automation-hub/_ui/v1/repo/rh-certified/namespace/name/
http://0.0.0.0:5001/api/automation-hub/_ui/v1/repo/rh-certified/
http://0.0.0.0:8002/ui/repo/rh-certified
http://0.0.0.0:8002/ui/repo/rh-certified/namespace/name
http://0.0.0.0:5001/api/automation-hub/_ui/v1/collection-versions/?repository=reponame
Copy Endpoint Added
Notes:
PR Author: Add a QE reviewer (exceptions);
Reviewers: look for sound code, no code smells, docs & test coverage
Merger: When merging, include the Jira issue link in the squashed commit