-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure repo deletion also removes associated content and artifacts #1603
Merged
newswangerd
merged 24 commits into
ansible:master
from
ShaiahWren:galaxy-not-deleting-repo
Feb 28, 2023
Merged
Ensure repo deletion also removes associated content and artifacts #1603
newswangerd
merged 24 commits into
ansible:master
from
ShaiahWren:galaxy-not-deleting-repo
Feb 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for galaxyng ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
github-actions
bot
added
backport-4.2
This PR should be backported to stable-4.2 (1.2)
backport-4.4
This PR should be backported to stable-4.4 (2.1)
backport-4.5
This PR should be backported to stable-4.5 (2.2)
backport-4.6
This PR should be backported to stable-4.6 (2.3)
labels
Jan 30, 2023
ShaiahWren
force-pushed
the
galaxy-not-deleting-repo
branch
15 times, most recently
from
February 4, 2023 15:09
6dd3550
to
eab21e1
Compare
newswangerd
removed
backport-4.2
This PR should be backported to stable-4.2 (1.2)
backport-4.4
This PR should be backported to stable-4.4 (2.1)
backport-4.5
This PR should be backported to stable-4.5 (2.2)
labels
Feb 6, 2023
ShaiahWren
force-pushed
the
galaxy-not-deleting-repo
branch
4 times, most recently
from
February 6, 2023 20:07
4b11c21
to
608f186
Compare
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
Issue: AAH-2024
ShaiahWren
force-pushed
the
galaxy-not-deleting-repo
branch
from
February 28, 2023 15:01
3459671
to
c8df9a7
Compare
newswangerd
approved these changes
Feb 28, 2023
Backport to stable-4.6: 💚 backport PR created✅ Backport PR branch: Backported as #1627 🤖 @patchback |
jerabekjiri
pushed a commit
to jerabekjiri/galaxy_ng
that referenced
this pull request
May 25, 2023
…nsible#1603) Issue: AAH-2024 (cherry picked from commit d1dfb7b)
jerabekjiri
added a commit
that referenced
this pull request
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: AAH-2024
Prior to this pr, the
delete_container_distribution
method deleted the repo from the system, yet the associated content and artifacts remained.To ensure all content is deleted, the content_pks in orphan cleanup for the method is now set to the content pks for the given repository and the orphan protection time, set to 0.
Plan of action:
That should be it!