[stable-4.7] AAP 2.4 Translations (2) #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rooftopcellist
changed the title
rooftopcellist
force-pushed
the
translations_updated_2023-05-10_12_09_49
branch
from
dd418e8
to
0d1f9de
Compare
jerabekjiri
approved these changes
May 11, 2023
himdel
reviewed
May 13, 2023
| msgid "Delete this task." | ||
| msgstr "" | ||
| msgstr "Supprimer ce nœud." |
There was a problem hiding this comment.
Suggested change
| msgstr "Supprimer ce nœud." | |
| msgstr "Supprimer ce tâche." |
?
There was a problem hiding this comment.
probably more:
Suggested change
| msgstr "Supprimer ce nœud." | |
| msgstr "Supprimer cette tâche." |
There was a problem hiding this comment.
The perks of having a French speaker on the team! ❤️
himdel
reviewed
May 13, 2023
|
|
||
| #: app/constants.py:76 | ||
| msgid "Edit this user." | ||
| msgstr "" | ||
| msgstr "Modificar este nodo" |
There was a problem hiding this comment.
Suggested change
| msgstr "Modificar este nodo" | |
| msgstr "Modificar este usuario" |
himdel
reviewed
May 13, 2023
|
|
||
| #: app/constants.py:82 | ||
| msgid "Delete this user." | ||
| msgstr "" | ||
| msgstr "Eliminar este nodo" |
There was a problem hiding this comment.
Suggested change
| msgstr "Eliminar este nodo" | |
| msgstr "Eliminar este usuario" |
himdel
reviewed
May 13, 2023
|
|
||
| #: app/constants.py:100 | ||
| msgid "Edit this group" | ||
| msgstr "" | ||
| msgstr "Modificar este nodo" |
There was a problem hiding this comment.
Suggested change
| msgstr "Modificar este nodo" | |
| msgstr "Modificar este grupo" |
himdel
reviewed
May 13, 2023
|
|
||
| #: app/constants.py:106 | ||
| msgid "Delete this group." | ||
| msgstr "" | ||
| msgstr "Eliminar este nodo" |
There was a problem hiding this comment.
Suggested change
| msgstr "Eliminar este nodo" | |
| msgstr "Eliminar este grupo" |
|
There seems to be some inconsistency with the translation of "Remotes" .. mando, vs remoto, vs "a distancia", is that something worth fixing? |
|
@rooftopcellist can you update the PR with @himdel's suggestions? |
|
@himdel I updated the PR with those suggestions, and a couple of the "remote" discrepancies that I was able to understand enough to change. it looks like CI failed on something unrelated |
rooftopcellist
force-pushed
the
translations_updated_2023-05-10_12_09_49
branch
from
3c550bd
to
b1ce0b3
Compare
himdel
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing:
Localization updates for AAP 2.4.
Replaces #1715
Reviewers must know:
PR Author & Reviewers: Keep or remove backport labels per Backporting Guidelines
Reviewers: Look for sound code, no code smells, docs & test coverage
Merger: When merging, include the Jira issue link in the squashed commit