Add a download counter for legacy roles. #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for galaxyng canceled.
|
github-actions
bot
added
backport-4.2
jctanner
removed
backport-4.2
jctanner
changed the title
awcrosby
approved these changes
May 17, 2023
jctanner
force-pushed
the
ROLE_DOWNLOAD_COUNTS
branch
3 times, most recently
from
01a07d4
to
d8c4022
Compare
* Use the same logic from galaxy's old codebase for determining a role download is happening. * Use a simple integer field instead of a table that could grow to a very large size. Issue: AAH-2238 Signed-off-by: James Tanner <tanner.jc@gmail.com>
jctanner
force-pushed
the
ROLE_DOWNLOAD_COUNTS
branch
from
d8c4022
to
1a97e4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same logic from galaxy's old codebase for determining a download is happening, which was "if the roles list view is called and the url contains parameters for owner__username and name, assume it's the CLI getting the details it needs to create the repo url and clone|download the role".
Use a simple integer field instead of a table that could grow to a very large size. The previous implementation incremented a counter on the [github] repository foreign key, which isn't part of the v1 rewrite.
Copy the old download_count when syncing v1 roles.
https://github.com/ansible/galaxy/blob/devel/galaxy/api/views/roles.py#L46-L63
Issue: AAH-2238