Update remote rh-certified default url #2032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backport-4.2
jctanner
approved these changes
Jan 16, 2024
|
Are we backporting this or should those labels be removed? |
jctanner
requested changes
Jan 16, 2024
The intent in modifying an existing migration is so that only new installations will get the updated URL so that we don't impact customers who might have already modified it. |
A new migration file can do a conditional update by checking the current value. |
|
With the new migration file, we can remove the change in the old file right? Also, should the backport labels be removed? |
drodowic
removed
backport-4.2
jctanner
approved these changes
Jan 19, 2024
rochacbruno
added
the
backport-4.9
Backport to stable-4.9: 💚 backport PR created✅ Backport PR branch: Backported as #2077 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Feb 21, 2024
AAP-15623 (cherry picked from commit 5b846b5)
rochacbruno
added a commit
to rochacbruno/galaxy_ng
that referenced
this pull request
Feb 21, 2024
Add /content/published to the default URL when setting up the default remotes. This has been fix on ansible#2032 but that PR not backported. This PR changes the original migration, so fresh installs gets the new URL and existing systems are not affected This must be backported to 4.9.z No-Issue Related: AAH-2836
rochacbruno
added a commit
to rochacbruno/galaxy_ng
that referenced
this pull request
Feb 29, 2024
Add /content/published to the default URL when setting up the default remotes. This has been fix on ansible#2032 but that PR not backported. This PR changes the original migration, so fresh installs gets the new URL and existing systems are not affected This must be backported to 4.9.z No-Issue Related: AAH-2836
rochacbruno
added a commit
that referenced
this pull request
Feb 29, 2024
Add /content/published to the default URL when setting up the default remotes. This has been fix on #2032 but that PR not backported. This PR changes the original migration, so fresh installs gets the new URL and existing systems are not affected This must be backported to 4.9.z No-Issue Related: AAH-2836
patchback bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
Add /content/published to the default URL when setting up the default remotes. This has been fix on #2032 but that PR not backported. This PR changes the original migration, so fresh installs gets the new URL and existing systems are not affected This must be backported to 4.9.z No-Issue Related: AAH-2836 (cherry picked from commit 5d56bdd)
rochacbruno
added a commit
that referenced
this pull request
Mar 1, 2024
… the correct URL for rh-certified (#2089) fix: Fresh installs must get the correct URL for rh-certified (#2078) Add /content/published to the default URL when setting up the default remotes. This has been fix on #2032 but that PR not backported. This PR changes the original migration, so fresh installs gets the new URL and existing systems are not affected This must be backported to 4.9.z No-Issue Related: AAH-2836 (cherry picked from commit 5d56bdd) Co-authored-by: Bruno Rocha <rochacbruno@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR doing:
AAP-15623
Reviewers must know:
PR Author & Reviewers: Keep or remove backport labels per Backporting Guidelines
Reviewers: Look for sound code, no code smells, docs & test coverage
Merger: When merging, include the Jira issue link in the squashed commit