Fixing pulpcore 3.10+ breaking changes and renamings #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulpcore 3.10 introduced some breaking changes - On serializers `highest_versions` has been removed out of the context - On download_url `content_artifact` has been also moved out of context - Sync now requires `optimize=True` attribute And also some non-breaking changes - On viewsets the `retrieve` is now part of pulp-ansible and can be removed from our side - `self._deprecation` is not necessary (included by mistake on a previous PR) Issue: AAH-393
|
Can one of the admins verify this patch? |
rochacbruno
requested review from
newswangerd,
hendersonreed,
cutwater and
awcrosby
awcrosby
reviewed
Feb 24, 2021
awcrosby
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulpcore 3.10 introduced some breaking changes
highest_versionshas been removed out of the contextcontent_artifacthas been also moved out of contextoptimize=TrueattributeAnd also some non-breaking changes
retrieveis not needed because distro_path is now part of pulp-ansible and can be removed from our sideself._deprecationis not necessary (included by mistake on aprevious PR)
Issue: AAH-393