Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add models for ContainerRegistry Sync Config #695

Merged
merged 2 commits into from Mar 22, 2021

Conversation

rochacbruno
Copy link
Member

@rochacbruno rochacbruno commented Mar 18, 2021

  • Add ContainerRegistryRemote as a subclass of core.Remote to hold
    configuration for syncing container repositories.
  • Add the link model ContainerRegistryRepos as a one-to-many linking
    ContainerRegistryRemote to container.Remote
  • Add ContainerSyncTask to save the history of sync tasks

Issue: AAH-432

galaxy dot

Graph made with

# make api/bash
./entrypoint.sh manage graph_models \
                        -g --dot --include-models "Container*,Remote*" \
                        -o src/galaxy.dot \ 
                        core container galaxy

then

from graphviz import render
render('dot', 'png', 'galaxy.dot')

- Add `ContainerRegistryRemote` as a subclass of `core.Remote` to hold
  configuration for syncing container repositories.
- Add the link model `ContainerRegistryRepos` as a one-to-many linking
  `ContainerRegistryRemote` to `container.Remote`
- Add `ContainerSyncTask` to save the history if sync tasks

Issue: AAH-432
@app-sre-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@alikins
Copy link
Contributor

alikins commented Mar 18, 2021

Kind of feels like this should live pulp_container?

Aside from basing the models from our access_policy mixins, is there anything else that makes this not suitable for pulp_container?

The need for using the access_policy mixins could be significant enough to require it in galaxy_ng, mostly asking out of curiosity.

@rochacbruno rochacbruno merged commit 5ea6db7 into ansible:master Mar 22, 2021
@rochacbruno rochacbruno deleted the aah-432.b branch March 22, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants