Make synclist task with policy 'exclude' include all versions not just is_latest AAH-485 #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alikins
requested review from
awcrosby,
bmclaughlin,
hendersonreed,
ironfroggy,
newswangerd and
rochacbruno
alikins
added
backport-4.3
Issue: AAH-585
Issue: AAH-585
alikins
force-pushed
the
sync_from_synclist_all_content_aah_585
branch
from
5cfe9e0
to
f9c7a5d
Compare
rochacbruno
reviewed
Jul 19, 2021
chouseknecht
removed request for
ironfroggy,
bmclaughlin,
awcrosby,
newswangerd and
hendersonreed
Issue: AAH-585
rochacbruno
approved these changes
Jul 20, 2021
rochacbruno
reviewed
Jul 20, 2021
awcrosby
approved these changes
Jul 20, 2021
newswangerd
approved these changes
Jul 21, 2021
Backport to stable-4.3: 💚 backport PR created✅ Backport PR branch: Backported as #854 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jul 21, 2021
…t is_latest AAH-485 (#783) * Just adding CHANGES/585.txt with some notes Issue: AAH-585 * Notes No-Issue * WIP: Set is_highest based on synlist.policy Issue: AAH-585 * Fix synclist include/exclude filter. Issue: AAH-585 Co-authored-by: Bruno Rocha <rochacbruno@gmail.com> (cherry picked from commit 3bdecca)
awcrosby
pushed a commit
to awcrosby/galaxy_ng
that referenced
this pull request
Aug 30, 2021
…t is_latest AAH-485 (ansible#783) * Just adding CHANGES/585.txt with some notes Issue: AAH-585 * Notes No-Issue * WIP: Set is_highest based on synlist.policy Issue: AAH-585 * Fix synclist include/exclude filter. Issue: AAH-585 Co-authored-by: Bruno Rocha <rochacbruno@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended fix for 'Syncing from synclist is pulling all content, ignoring sync toggles'
https://issues.redhat.com/browse/AAH-585?focusedCommentId=16232352&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16232352 goes into details about the root cause.
I think the synclist 'curate' is only removing the latest version of the collection from the synclist RepositoryVersion instead of all the versions when the synclist.policy=='exclude'.
This pr is a WIP that sets
is_highest=Falsefor exclude case.Issue: AAH-485