Deploy to ephemeral env in pr_check #791
Conversation
bmclaughlin
force-pushed
the
deploy-to-ephemeral-environment
branch
from
a763d57
to
c7c62f1
Compare
Issue: AAH-582
bmclaughlin
force-pushed
the
deploy-to-ephemeral-environment
branch
from
c7c62f1
to
dace112
Compare
|
Looks ok to me, assuming But I know nothing of clowder, so not a review. |
| namespace: automation-hub | ||
| spec: | ||
| # The name of the ClowdEnvironment providing the services | ||
| envName: automation-hub-env |
There was a problem hiding this comment.
you may want to use ${ENV_NAME} for the value and add a parameter ENV_NAME which will be assigned by e.g. the prod env value here https://gitlab.cee.redhat.com/service/app-interface/blob/master/data/products/insights/environments/production.yml#L53
openshift/clowder/clowd-app.yaml
Outdated
| deployments: | ||
| - name: galaxy-api | ||
| podSpec: | ||
| image: quay.io/cloudservices/automation-hub-galaxy-ng |
There was a problem hiding this comment.
You would want to parameterized the image tag e.g.
image: quay.io/cloudservices/automation-hub-galaxy-ng:${IMAGE_TAG}
openshift/clowder/clowd-app.yaml
Outdated
| name: automation-hub | ||
| version: 12 | ||
| # Creates a Service on port 8000 | ||
| webServices: |
There was a problem hiding this comment.
webServices is per deployment as in https://redhatinsights.github.io/clowder/clowder/dev/api_reference.html#k8s-api-cloud-redhat-com-clowder-v2-apis-cloud-redhat-com-v1alpha1-webservices
So in one clowd app, you can have multiple webservices
Issue: AAH-582
bmclaughlin
force-pushed
the
deploy-to-ephemeral-environment
branch
from
d81f707
to
adec54f
Compare
Issue: AAH-582
bmclaughlin
force-pushed
the
deploy-to-ephemeral-environment
branch
from
adec54f
to
c56405e
Compare
* Deploy Automation Hub to ephemeral environments. * Correct clowd-app template in order to deploy to ephemeral env * Parameterize ENV_NAME, IMAGE_NAME, IMAGE_TAG * Move webServices key under galaxy-api deployment Issue: AAH-582 (cherry picked from commit 5998f2a62c720e311a77248a9814bb67331cf2ea)
Draft PR until #776, #786 are merged.Merged.Issue: AAH-582